Merged
Conversation
LambdAurora
reviewed
Mar 12, 2026
Owner
There was a problem hiding this comment.
Thanks a lot!
I definitely would:
- do more renames to the
extract*RenderStatescheme, it's more accurate and can't live in the past all the time; - rename the GuiGraphics mixin to make it fit the new name;
- not rename
SpruceGuiGraphicsbecause it's already quite long 😅; - rename methods in
SpruceGuiGraphicsso the pass-through methods still matchGuiGraphicsExtractorso we avoid potentially confusion.
| target = "Lnet/minecraft/client/gui/screens/Screen;renderWithTooltipAndSubtitles(Lnet/minecraft/client/gui/GuiGraphics;IIF)V" | ||
| target = "Lnet/minecraft/client/gui/screens/Screen;extractRenderStateWithTooltipAndSubtitles(Lnet/minecraft/client/gui/GuiGraphicsExtractor;IIF)V" | ||
| ), | ||
| // FIXME: see what Neoforge names this hook. |
Owner
There was a problem hiding this comment.
Currently the NeoForge signature is still the same.
Though, it may still change which puts us in a delicate spot for now.
Arguably, it'd be much nicer if they used mixins for this. >:(
Contributor
Author
There was a problem hiding this comment.
I'll leave it as-is in the meantime. Tho, saying that, the vanilla call is missing in NeoForge, so; it'll, break either way of: it's left commented out, always causing a mixin error on startup, or it's active but they changed the name mid-way through, causing a mixin error on startup then.
The render functions have been renamed to align with Vanilla's naming convention; i.e. - render -> extractRenderState - renderWidget -> extractWidgetRenderState - render\* -> extract\*, foregoing the `RenderState` suffix, similar to Vanilla.
Simplifies the build setup and takes advantage of the global cache, if theh dependencies allow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also has a side-commit of fixing the Neoforged Maven URI.
Various acknowledgements of subpars:
render*methods that overrode Vanilla have been renamed toextract*RenderStaterender*functions should follow the same convention ofextract*RenderStateorextractGuiin the case of rendering a screen.